-
Notifications
You must be signed in to change notification settings - Fork 10
fix: CICD pipeline to use Runner to Upload images to ECR #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes the CI/CD pipeline by consolidating image building and ECR pushing to self-hosted runners, eliminating duplicate builds and resolving storage constraints from larger vLLM images.
- Introduces parallel matrix builds for vllm, attestation, and api images using 3 concurrent self-hosted runners
- Moves image building from E2E test job to dedicated build-images job that runs before tests
- Replaces GitHub runners with self-hosted runners for ECR push operations to handle larger image sizes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| build_args: "--target nilai --platform linux/amd64" | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 |
Copilot
AI
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using outdated checkout action version v2. Should use actions/checkout@v4 for better performance and security features, consistent with other jobs in the workflow.
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v4 |
| if: ${{ always() }} | ||
| steps: | ||
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v1 |
Copilot
AI
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using outdated aws-actions/configure-aws-credentials@v1. Should use v4 for consistency with the push-images job and to benefit from latest security updates and features.
| uses: aws-actions/configure-aws-credentials@v1 | |
| uses: aws-actions/configure-aws-credentials@v4 |
Summary
This PR main motivation is fixing a bug that used all storage space in Github action runners and prevented from uploading the artifacts to ECR.Optimize CI pipeline for better performance and reliability by leveraging self-hosted runners for image building and deployment.
Key Changes
Consolidated Build & Push Pipeline
Parallel Image Building
runners-per-machine: 3)vllm,attestation, andapinow run in parallel📦 vLLM Size Compatibility
Pipeline Flow
test → start-runner → [build-images × 3] → e2e-tests → [push-images × 3] → stop-runner
Performance Improvements