refactor: update nilrag operation to use new nilrag api #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manel1874
force-pushed
the
refactor/update-nilrag-api
branch
from
f863bb3 to
40e1f50
Compare
manel1874
force-pushed
the
refactor/update-nilrag-api
branch
from
389e577 to
de6926b
Compare
jimouris
approved these changes
Apr 11, 2025
jcabrero
approved these changes
Apr 11, 2025
Member
jcabrero
left a comment
jcabrero
left a comment
There was a problem hiding this comment.
The PR looks good. I cannot see the CI having passed, and it would be great if you could get it working before merging.
Contributor
Author
|
They passed here: https://github.com/NillionNetwork/nilAI/actions/runs/14360234283 For some obscure reason it does not show up here. I re-ran them again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the code from nilAI and uses the new function from nilrag (check nilrag PR).
Note: