Fix float-parsing logic #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalmodi
force-pushed
the
fix-float-parsing
branch
from
3e4c2da
to
7c18145
Compare
timotheecour
approved these changes
Jun 7, 2021
With the float string representation fixed in Nim devel (See nim-lang/Nim#18139), that uncovered a bug in the logic for parsing float TOML values. For e.g. to parse "foo = 0.123", internally, 0.1 + 0.02 + 0.003 was done which would evaluate to 0.12300000000000001. Earlier float stringification bug caused that value to print out as "0.123" instead of "0.12300000000000001". This is now fixed by using parseutils.parsefloat, which parses the "0.123" float value as 0.123 and not 0.12300000000000001. Fixes NimParsers#45.
kaushalmodi
force-pushed
the
fix-float-parsing
branch
from
7c18145
to
0a1d2e4
Compare
|
Thanks for fixing this, it was a remnant of the original parser that was bound to break at some point. Haven't had the time to run this PR through the test-suite for TOML by burnt-sushi, but it looks like it should work at least. |
|
@PMunch Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the float string representation fixed in Nim devel (See
nim-lang/Nim#18139), that uncovered a bug in
the logic for parsing float TOML values.
For e.g. to parse "foo = 0.123", internally, 0.1 + 0.02 + 0.003 was
done which would evaluate to 0.12300000000000001. Earlier
float stringification bug caused that value to print out as "0.123"
instead of "0.12300000000000001".
This is now fixed by using parseutils.parsefloat, which parses the
"0.123" float value as 0.123 and not 0.12300000000000001.
Fixes #45.
/cc @timotheecour Request to review this PR.