Fixed some crashes and small issues

config/harpoon.nim

@@ -172,7 +172,10 @@ proc defaultEncode(item: HarpoonItem): string =
   return $item.toJson
 
 proc defaultDecode(value: string): HarpoonItem =
-  return value.parseJson.jsonTo(HarpoonItem)
+  try:
+    return value.parseJson.jsonTo(HarpoonItem)
+  except:
+    return HarpoonItem()
 
 proc defaultCreateListItem(config: HarpoonPartialConfigItem, name: Option[string]): HarpoonItem =
   let activeEditor = if getActiveEditor().isTextEditor(ed):
@@ -226,7 +229,11 @@ proc encode(list: HarpoonList): Option[seq[string]] =
   for item in list.items:
     var encoded = ""
     if encodeCallback != "":
-      encodeCallback.invoke(encoded, item)
+      try:
+        encodeCallback.invoke(encoded, item)
+      except:
+        infof"Failed to encode item {item}"
+        continue
     else:
       encoded = defaultEncode(item)
 
@@ -253,7 +260,7 @@ proc getList(self: Harpoon, name: Option[string] = string.none): var HarpoonList
   else:
     key = ""
 
-  let lists = self.lists.mgetOrPut(key).addr
+  let lists = self.lists.mgetOrPut(key, initTable[string, HarpoonList]()).addr
 
   if lists[].contains(name):
     return self.lists[key][name]

scripting/absytree_runtime.nim

@@ -20,7 +20,7 @@ type AnyDocumentEditor = TextDocumentEditor | ModelDocumentEditor
 var voidCallbacks = initTable[int, proc(args: JsonNode): void]()
 var boolCallbacks = initTable[int, proc(args: JsonNode): bool]()
 var anyCallbacks = initTable[int, proc(args: JsonNode): JsonNode]()
-var onEditorModeChanged*: Event[tuple[editor: EditorId, oldMode: string, newMode: string]]
+var onEditorModeChanged* = initEvent[tuple[editor: EditorId, oldMode: string, newMode: string]]()
 var callbackId = 0
 
 when defined(wasm):

scripting/absytree_runtime_impl.nim

@@ -6,8 +6,12 @@ proc handleAnyCallback*(id: int, args: JsonNode): JsonNode = handleAnyCallbackIm
 proc handleScriptAction*(name: string, args: JsonNode): JsonNode = handleScriptActionImpl(name, args)
 
 proc handleEditorModeChanged*(editor: EditorId, oldMode: string, newMode: string) =
-  # infof"handleEditorModeChanged {editor} {oldMode} {newMode}"
-  onEditorModeChanged.invoke (editor, oldMode, newMode)
+  try:
+    # todo: in nimscript this crashes?
+    when not defined(nimscript):
+      onEditorModeChanged.invoke (editor, oldMode, newMode)
+  except:
+    info &"handleEditorModeChanged failed: {getCurrentExceptionMsg()}\n{getCurrentException().getStackTrace()}"
 
 when defined(wasm):
   proc postInitializeWasm(): bool {.wasmexport.} =

src/app.nim

@@ -739,10 +739,15 @@ proc initScripting(self: App, options: AppOptions) {.async.} =
 
         if self.homeDir != "":
           let scriptPath = self.homeDir / ".absytree/custom.nims"
-          if createScriptContext(scriptPath, searchPaths).await.getSome(scriptContext):
-            self.nimsScriptContext = scriptContext
+          if fileExists(scriptPath):
+            log lvlInfo, &"Found '{scriptPath}'"
+            if createScriptContext(scriptPath, searchPaths).await.getSome(scriptContext):
+              self.nimsScriptContext = scriptContext
+            else:
+              log lvlError, "Failed to create nim script context"
+
           else:
-            log lvlError, "Failed to create nim script context"
+            log lvlInfo, &"No custom.nims found in home ~/.absytree"
 
           withScriptContext self, self.nimsScriptContext:
             log(lvlInfo, fmt"init nim script config")

src/misc/event.nim

@@ -4,6 +4,9 @@ import id, util
 type Event*[T] = object
   handlers: seq[tuple[id: Id, callback: (T) -> void]]
 
+proc initEvent*[T](): Event[T] =
+  result = Event[T](handlers: @[])
+
 proc subscribe*[T: void](event: var Event[T], callback: () -> void): Id =
   assert callback != nil
   result = newId()