Updated the instantiation process as per the async. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please remove .DS_Store and .sqlx folder/file |
NishantJoshi00
requested changes
Feb 12, 2025
src/runtime_v2/service.rs
Outdated
| @@ -284,3 +342,91 @@ impl server_traits::DriverDetails for super::Runtime { | |||
| })) | |||
| } | |||
| } | |||
|
|
|||
| // #[tonic::async_trait] | |||
| @@ -0,0 +1 @@ | |||
| UPI_HOST=34.93.161.62 | |||
Comment on lines
12
to
16
| # grpcurl -plaintext -d @ localhost:8080 finternet.PrintMessage/Print <<EOM | ||
| # { | ||
| # "message":"hello grpc" | ||
| # } | ||
| # EOM |
src/server.rs
Outdated
Comment on lines
101
to
102
| // .add_service(user_sign_up_service) | ||
| // .add_service(user_login_sevice) |
There was a problem hiding this comment.
don't keep commented code
src/runtime_v2/storage/sql.rs
Outdated
| @@ -170,6 +170,7 @@ impl DriverStorage for SqliteStorage { | |||
| driver_info: &DriverInfo, | |||
| engine: wasmtime::Engine, | |||
| ) -> Result<Option<Component>> { | |||
| println!("i will panic here"); | |||
src/runtime_v2/service.rs
Outdated
| @@ -35,6 +84,7 @@ impl server_traits::Execution for super::Runtime { | |||
| &self, | |||
| request: Request<types::ExecutionRequest>, | |||
| ) -> Result<Response<types::ExecutionResponse>, tonic::Status> { | |||
| // let user_id= get_user_id(&request).map_err(|e| tonic::Status::internal(e.to_string()))?; | |||
src/runtime_v2/service.rs
Outdated
| None => return Err(Box::new(Status::unauthenticated("No JWT token found"))), | ||
| }; | ||
|
|
||
| let secret = b"finternet"; |
There was a problem hiding this comment.
don't hardcode secrets take them from the config
src/runtime_v2.rs
Outdated
| wasmtime_wasi::add_to_linker_async(&mut linker).map_err(|err| { | ||
| types::component::module::component::units::driver::DriverError::SystemError(err.to_string()) | ||
| })?; | ||
| println!("error is here"); |
| @@ -134,7 +135,7 @@ struct Config { | |||
| impl Config { | |||
| fn new() -> Self { | |||
| Config { | |||
| host: format!("http://{}:8030", env!("UPI_HOST")), | |||
| host: format!("http://34.93.161.62:8030"), | |||
There was a problem hiding this comment.
please use env, don't do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.