Specific user api like login and signup #12
Conversation
| username TEXT NOT NULL, | ||
| userid TEXT NOT NULL PRIMARY KEY, | ||
| password TEXT NOT NULL |
There was a problem hiding this comment.
| username TEXT NOT NULL, | |
| userid TEXT NOT NULL PRIMARY KEY, | |
| password TEXT NOT NULL | |
| user_name TEXT NOT NULL, | |
| user_id TEXT NOT NULL PRIMARY KEY, | |
| password TEXT NOT NULL |
| @@ -1 +1,2 @@ | |||
| /target | |||
| /src/.envrc | |||
There was a problem hiding this comment.
this looks wrong, please verify. It should be on
| /src/.envrc | |
| /.envrc |
| impl Config { | ||
| fn new() -> Self { | ||
| Config { | ||
| host: format!("http://{}:8030", env!("UPI_HOST")), | ||
| host: format!("http://{}:8030",env::var("UPI_HOST").unwrap()), |
There was a problem hiding this comment.
This is also wrong, this will not work. the old code used env! which fetches the env at compile time and adds them. This does it on runtime. We don't support environment variable at runtime yet.
| { | ||
| "input": "{ \"path1\": \"/upi/person1\", \"path2\": \"/upi/person2\", \"amount\": 10 }", | ||
| "input": "{ \"path1\": \"~/amit/mono\", \"path2\": \"/accounts/Nishant1234/nishant/mono\", \"amount\": 10 }", |
There was a problem hiding this comment.
This should be:
| "input": "{ \"path1\": \"~/amit/mono\", \"path2\": \"/accounts/Nishant1234/nishant/mono\", \"amount\": 10 }", | |
| "input": "{ \"path1\": \"~/mono\", \"path2\": \"/accounts/Nishant1234/mono\", \"amount\": 10 }", |
proto/user.proto
Outdated
| string username = 1; | ||
| string name =2; | ||
| string email = 3; | ||
| string password = 4; |
There was a problem hiding this comment.
please have consistent formatting
src/runtime_v2/service.rs
Outdated
| Err(_err) => { | ||
| return Ok(UserData{ | ||
| message: false, | ||
| username: "".to_string(), |
There was a problem hiding this comment.
this looks wrong, if you want to reset, please make username an Option<T> type instead of empty string.
src/runtime_v2/service.rs
Outdated
| None => return Err(Box::new(Status::unauthenticated("No JWT token found"))), | ||
| }; | ||
|
|
||
| let secret = env::var("secret").unwrap_or_else(|_| "default_value".to_string()); |
There was a problem hiding this comment.
same here, and consider using a single defined constant for the environment variable if you are going with .b approach
src/runtime_v2/service.rs
Outdated
| let mut process_state = ProcessState::new( | ||
| UserCtx { | ||
| user_id: "root".to_string(), | ||
| user_id:user_id.to_string(), |
There was a problem hiding this comment.
please consider running cargo +nightly fmt
src/runtime_v2/service.rs
Outdated
| .unwrap() | ||
| .as_secs() as usize, | ||
| }; | ||
| let secret = env::var("secret").unwrap_or_else(|_| "default_value".to_string()); |
src/runtime_v2/storage/sql.rs
Outdated
|
|
||
| #[async_trait] | ||
| impl UserStorage for SqliteStorage { | ||
| async fn insert(&self,username: &str, password: &str) -> Result<String> { |
There was a problem hiding this comment.
insert of replace is a dangerous operation. This can overwrite a genuine user with someone random. Imagine if someone recreates the icici account? That would be bad. Only use insert.
No description provided.