Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature 13b] Display HUD window #97

Merged
merged 12 commits into from
Dec 23, 2022
Merged

[feature 13b] Display HUD window #97

merged 12 commits into from
Dec 23, 2022

Conversation

Vio1625
Copy link
Collaborator

@Vio1625 Vio1625 commented Dec 22, 2022

Display all HUD window except for action cards

@Vio1625 Vio1625 added the feature New feature or request label Dec 22, 2022
@Vio1625 Vio1625 requested review from NiskuT and jard-111 December 22, 2022 15:44
@Vio1625 Vio1625 closed this Dec 22, 2022
@Vio1625 Vio1625 changed the title Feature 13b [feature 13b] Display HUD window Dec 22, 2022
@Vio1625 Vio1625 reopened this Dec 22, 2022
NiskuT
NiskuT requested changes Dec 22, 2022
View reviewed changes
Copy link
Owner

@NiskuT NiskuT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code bring good improvements, I have added some comment to make it even more clear. Feel free to address them

src/client/TextureDisplayer.cpp Outdated Show resolved Hide resolved
src/client/TextureDisplayer.cpp Outdated Show resolved Hide resolved
src/client/TextureDisplayer.cpp Outdated Show resolved Hide resolved
src/client/GameWindow.cpp Outdated Show resolved Hide resolved
src/client/GameWindow.cpp Show resolved Hide resolved
resources/img/hud/priority-card.json Outdated Show resolved Hide resolved
NiskuT
NiskuT previously approved these changes Dec 23, 2022
View reviewed changes
@Vio1625 Vio1625 requested review from lucas-mrq and removed request for jard-111 December 23, 2022 16:41
@Vio1625 Vio1625 merged commit cf2b9ec into develop Dec 23, 2022
@Vio1625 Vio1625 deleted the feature-13b branch December 23, 2022 16:59
@Vio1625 Vio1625 linked an issue Dec 23, 2022 that may be closed by this pull request
[feature-13] Display the HUD window #74
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiskuT NiskuT NiskuT left review comments

@lucas-mrq lucas-mrq lucas-mrq approved these changes

Assignees

@NiskuT NiskuT

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature-13] Display the HUD window
3 participants
@Vio1625 @NiskuT @lucas-mrq