Complete Qt6/PySide6 migration #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
force-pushed
the
qt6-full
branch
2 times, most recently
from
3328053 to
9169c7f
Compare
This was referenced Dec 18, 2023
Closed
* convert enums to full paths for qt6 * change all `PyQt5` occurences to `PyQt6` * rename all pyqtSlot/pyqtSignal to Slot/Signal * temporary move to pyside6 tooling for ui compilation * some unused code removed
* various cleanups for icons and ui-widgets * remove old 'about_dialog.py' and its '.ui' * no need to compile resources anymore, now filepaths are used directly * no need to compile '.ui' files to '.py' anymore, QUiLoader takes care during runtime
* introduce new `load_ui()` that properly injects into current instance * automated resizing of inner widgets works again * rename evil 'widget' to 'line_widget' inside `secrets_tab.ui`
remember - don't try to overwrite Qt's `.connect` method!
* add pyqt6-stubs * bump pynitrokey to 0.4.43
* center nitrokey logo in left frame * proper layout design for the left frame
mmerklinger
approved these changes
Dec 19, 2023
Closed
This was referenced Jan 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes: #181 & #176
This is a complete migration to PySide6 including:
poetrypynitrokeyto0.4.43uiand icons from files directly*.uireferenced files shall be relative to theui/directory (set as workdir during inUiLoader)ui/andbakitselfQUiLoaderto populate the owningQWidgetinstead of creating aQWidgetinside anotherQWidget