fix: improve forwards compatibility with spsdk 2.1+ #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! We are currently working on vendoring the spsdk dependency to avoid many unnecessary dependencies, see: #519. I’m not sure if that will make it into the next release though. Therefore I’d hold off on merging this to avoid additional merge conflicts with #519. If we are closer to a release, we can decide which one to merge. |
daringer
approved these changes
Apr 17, 2024
|
Updated to just use |
spsdk recently switched to the python-native Enum library and renamed the `desc` method to `get_description` in the process. By using device.status_string instead, our code works with both versions. Co-authored-by: Robin Krahl <robin@nitrokey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes an incompatibility with spsdk 2.1 which is shipped in Arch Linux. spsdk recently switched to the python-native Enum library and renamed the
descmethod toget_descriptionin the process.Changes
get_descriptionis called first and falls back todesc.Checklist
Make sure to run
make checkandmake fixbefore creating a PR, otherwise the CI will fail.Feel free to make this change without attribution if you don’t feel comfortable merging it without the checks :)
Test Environment and Execution
Cheers
Konrad