Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNSET command. Passing ALL removes all user-defined vars, can also u... #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

a1270
Copy link
Contributor

@a1270 a1270 commented Nov 21, 2013

...nset specific variables. Implements #261. Readme updates are in #203.

@a1270
Copy link
Contributor Author

a1270 commented Nov 21, 2013

Should a reboot clear locks and user-defined vars?

@a1270
Copy link
Contributor Author

a1270 commented Nov 21, 2013

I agree that we should fix the underlying issues. I can't think of a good solution thus have been waiting for Nivekk to come back.

I should probably clarify and say the clearing would happen on a manual reboot. I think of the reboot command as a hard cycle where it returns the original state of the machine. Shutdown saves the state as it's safe. I can see issues where you shutdown and then reboot. You want the state after the shutdown and get a stock machine.

Saying all that, the REBOOT and SHUTDOWN commands seem rather useless. I have only used them to test clearing locks/vars. I can't think of a reason you'd ever use them in a script.

@a1270
Copy link
Contributor Author

a1270 commented Nov 21, 2013

How'd you start it back up? I know that you can toggle power, you could do that to shutdown. A PAUSE/RESUME would be more useful but i haven't fully worked that out yet.

The current issue with the parsing is that it has no idea what the saved vars are thus sends it through Expression. So you save a number as scientific notation "1E-50" and it trues to subtract 50 from E. I had one test branch that added nodes under variables for the types and added all the applicable vars to those. I abandoned that for some reason that i can't recall. I'll try to find it.

@a1270
Copy link
Contributor Author

a1270 commented Nov 22, 2013

No, only user-defined variables. REMOVE ALL NODES is in planning for removal of nodes and need to think about unlocking TARGET. I am holding off on the non-critical bugs until @Nivekk gets back as to not totally overwhelm him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant