Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New expr-c EvalState construction is causing build problems for 24.05. #11039

Closed
roberth opened this issue Jul 4, 2024 · 3 comments · Fixed by #11080
Closed

New expr-c EvalState construction is causing build problems for 24.05. #11039

roberth opened this issue Jul 4, 2024 · 3 comments · Fixed by #11080
Assignees
@Ericson2314
Labels
build-problem Nix fails to compile or test; also improvements to build process macos Nix on macOS, aka OS X, aka darwin

Comments

@roberth
Copy link
Member

roberth commented Jul 4, 2024

Originally posted in #10913 (comment)

This is causing problems for 24.05.
Might a simpler solution be feasible?

https://github.com/NixOS/nixpkgs/pull/324408/checks?check_run_id=27026504754
@roberth roberth added the build-problem Nix fails to compile or test; also improvements to build process label Jul 4, 2024
@roberth roberth mentioned this issue Jul 4, 2024
Merged
13 tasks
@roberth roberth added the macos Nix on macOS, aka OS X, aka darwin label Jul 10, 2024
@Ericson2314 Ericson2314 changed the title New EvalState construction is causing build problems for 24.05. New expr-c EvalState construction is causing build problems for 24.05. Jul 10, 2024
@emilazy
Copy link
Member

emilazy commented Jul 10, 2024

See https://github.com/NixOS/nixpkgs/pull/326172/files for the fix. This is currently broken in the flake, too.

@roberth roberth mentioned this issue Jul 11, 2024
Merged
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-07-08-nix-team-meeting-minutes/49099/1

@emilazy
Copy link
Member

emilazy commented Jul 15, 2024

FWIW I think using this C++ feature is totally fine. It’s only x86_64-darwin’s ancient SDK situation that even made it a problem in any way. The fix shouldn’t impact macOS version compatibility at all, and I believe @reckenrode mentioned we might as well even just patch out the Clang error that needed working around as it doesn’t apply to the Nixpkgs use‐case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ericson2314 Ericson2314

Labels
build-problem Nix fails to compile or test; also improvements to build process macos Nix on macOS, aka OS X, aka darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

packaging: Set darwinMinVersion to fix x86_64-darwin build NixOS/nix
4 participants
@roberth @Ericson2314 @emilazy @nixos-discourse