No global eval settings in libnixexpr
#10913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Ericson2314
commented
Jun 14, 2024
Ericson2314
force-pushed
the
no-global-eval-settings-in-libexpr
branch
from
fab536d to
df54688
Compare
Ericson2314
commented
Jun 14, 2024
|
Is there a use case where we could have multiple |
|
@edolstra Evaluating completely independent things. Could be part of an application with a long-lived process, or it could be part of the unit tests. The latter one may be just testing, but it's a fully non-hypothetical real one today. |
Ericson2314
requested review from
fricklerhandwerk,
roberth and
edolstra
as code owners
Ericson2314
force-pushed
the
no-global-eval-settings-in-libexpr
branch
from
df54688 to
4fd6441
Compare
Progress on #5638 There is still a global eval settings, but it pushed down into `libnixcmd`, which is a lot less bad a place for this sort of thing.
Ericson2314
force-pushed
the
no-global-eval-settings-in-libexpr
branch
from
4fd6441 to
52bfccf
Compare
github-actions
bot
added
with-tests
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-06-24-nix-team-meeting-minutes-155/47739/1 |
roberth
reviewed
Jul 4, 2024
Comment on lines
+110
to
+112
| void * p = ::operator new( | ||
| sizeof(EvalState), | ||
| static_cast<std::align_val_t>(alignof(EvalState))); |
There was a problem hiding this comment.
This is causing problems for 24.05.
Might a simpler solution be feasible?
https://github.com/NixOS/nixpkgs/pull/324408/checks?check_run_id=27026504754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Progress on #5638
Context
There is still a global eval settings, but it pushed down into
libnixcmd, which is a lot less bad a place for this sort of thing.Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.