Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildenv: perl -> c++ #1020

Merged
merged 1 commit into from
Aug 11, 2016
Merged

buildenv: perl -> c++ #1020

merged 1 commit into from
Aug 11, 2016

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Aug 10, 2016

No description provided.

@shlevy shlevy added this to the perl-to-c++ milestone Aug 10, 2016
@shlevy shlevy mentioned this pull request Aug 10, 2016
12 tasks
* because they would cauase pointless collisions (e.g., each
* Python package brings its own
* `$out/lib/pythonX.Y/site-packages/easy-install.pth'.)
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to nit, but is this comment accurate? I don't see how $out/lib/pythonX.Y/site-packages/easy-install.pth is excluded by the below suffix list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I just copied the comment from the perl script but you're right. @edolstra any idea about this? Should that be on the list?

@edolstra
Copy link
Member

I get:

$ ./inst/bin/nix-env -u subversion
building path(s) ‘/nix/store/xzglpy4plm5cpfx2iparghg9mj1q3cay-user-environment’
error: creating symlink from ‘/nix/store/xzglpy4plm5cpfx2iparghg9mj1q3cay-user-environment/nix-support’ to ‘/nix/store/hhs78ipwx5rz1692xns71086viy0yf6i-unrar-5.3.9/nix-support’: File exists
builder for ‘/nix/store/59p1rpz6x8b84kn1zib8v00dff2aw8lh-user-environment.drv’ failed with exit code 1
error: build of ‘/nix/store/59p1rpz6x8b84kn1zib8v00dff2aw8lh-user-environment.drv’ failed

Looks like /nix-support is not filtered correctly.

@edolstra
Copy link
Member

BTW, it would be nice to change buildenv into a builtin derivation (see builtinFetchurl). That way, we wouldn't need any special hacks anymore for running in a chroot (the chrootDeps in corepkgs/config.nix.in).

@shlevy
Copy link
Member Author

shlevy commented Aug 11, 2016

Oops, broke the filtering in a pre-push cleanup, fixing.

@shlevy
Copy link
Member Author

shlevy commented Aug 11, 2016

@edolstra should be pretty straightforward to do the builtin derivation on top of this change, right? I'd rather focus my nix efforts on finishing up the perl rewrite.

@edolstra
Copy link
Member

@shlevy Sure.

@shlevy
Copy link
Member Author

shlevy commented Aug 11, 2016

@edolstra fixed

@edolstra edolstra merged commit 91978e3 into NixOS:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants