fix: Treat empty TMPDIR as unset #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Mar 23, 2024
roberth
force-pushed
the
fix-empty-TMPDIR
branch
from
ee547d5 to
f5577ae
Compare
Fixes an instance of
nix: src/libutil/util.cc:139: nix::Path nix::canonPath(PathView, bool): Assertion `path != ""' failed.
... which I've been getting in one of my shells for some reason.
I have yet to find out why TMPDIR was empty, but it's no reason for
Nix to break.
See preceding commit. Not observed in the wild, but is sensible and consistent with TMPDIR behavior.
roberth
force-pushed
the
fix-empty-TMPDIR
branch
from
f5577ae to
3b7f2bf
Compare
github-actions
bot
added
the
store
This was referenced Mar 24, 2024
Merged
roberth
added
the
backport 2.18-maintenance
This comment was marked as resolved.
This comment was marked as resolved.
roberth
added a commit
that referenced
this pull request
Jun 10, 2024
[Backport 2.18-maintenance] fix: Treat empty TMPDIR as unset (#10303)
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
This is a squash of upstream PRs NixOS#10303, NixOS#10312 and NixOS#10883. fix: Treat empty TMPDIR as unset Fixes an instance of nix: src/libutil/util.cc:139: nix::Path nix::canonPath(PathView, bool): Assertion `path != ""' failed. ... which I've been getting in one of my shells for some reason. I have yet to find out why TMPDIR was empty, but it's no reason for Nix to break. (cherry picked from commit c3fb2aa) fix: Treat empty XDG_RUNTIME_DIR as unset See preceding commit. Not observed in the wild, but is sensible and consistent with TMPDIR behavior. (cherry picked from commit b9e7f5a) local-derivation-goal.cc: Reuse defaultTempDir() (cherry picked from commit fd31945) fix: remove usage of XDG_RUNTIME_DIR for TMP (cherry picked from commit 1363f51) tests/functional: Add count() (cherry picked from commit 6221770) Remove uncalled for message (cherry picked from commit b1fe388) Add build-dir setting (cherry picked from commit 8b16cce) Change-Id: Ic7b75ff0b6a3b19e50a4ac8ff2d70f15c683c16a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes an instance of
... which I've been getting in one of my shells for some reason. I have yet to find out why TMPDIR was empty in my shell, but it's no excuse for Nix to break.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.