Fix #10747 #10758
Merged
Fix #10747 #10758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
May 22, 2024
| @@ -580,7 +580,12 @@ struct curlFileTransfer : public FileTransfer | |||
| #endif | |||
|
|
|||
| #if __linux__ | |||
| unshareFilesystem(); | |||
| try { | |||
| tryUnshareFilesystem(); | |||
There was a problem hiding this comment.
Shouldn't the try/catch be moved inside tryUnshareFilesystem() since it claims to be best-effort?
There was a problem hiding this comment.
@edolstra This try-catch-rethrow is solely to add some error context. The actual error handling still happens in the caller.
There was a problem hiding this comment.
Maybe it should never throw an exception? Are there any errors that should not be ignored?
There was a problem hiding this comment.
I am not sure, but I am generally uncomfortable with ignoring errors without a whitelist.
edolstra
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ENOSYStoo which looks like it would solve run nix in a non root container in openshift - restricted SCC #10747Context
Fix #10747
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.