nix-profile.fish: Look for ca-bundle.crt in $NIX_PROFILES #12424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be no good reason for `nix-profile.fish` and `nix-profile-daemon.fish` to differ in how they look for the location of the `ca-bundle.crt` that might be installed by one of the packages. As `$NIX_PROFILES` points to user local paths, not checking there is strictly less useful, it seems?
ilya-bobyr
force-pushed
the
fish-profile-unify-ca-bundle.crt-search
branch
from
01bab37 to
23f07fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There seems to be no good reason for
nix-profile.fishandnix-profile-daemon.fishto differ in how they look for the location of theca-bundle.crtthat might be installed by one of the packages.As
$NIX_PROFILESpoints to user local paths, not checking there is strictly less useful, it seems?Context
Reduce differences between
nix-profile.fishandnix-profile-daemon.fish.This covers both points 8 and 9 in a list of the differences between
nix-profile.fishandnix-profile-daemon.fish.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.