libutil: Add missing format arguments to UsageError ctor #13094
Merged
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once again found by an automated migration to `std::format`. I've tested that boost::format works fine with `std::string_view` arguments.
xokdvium
force-pushed
the
file-content-address-fmt-string
branch
from
0964f96 to
9fff868
Compare
edolstra
added
the
backport 2.28-maintenance
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2025
…3094 libutil: Add missing format arguments to UsageError ctor (backport #13094)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Once again found by an automated migration to
std::format. I've tested that boost::format works fine withstd::string_viewarguments. https://godbolt.org/z/cqPeszxcPContext
More of the same stuff as in #13086 and #13087.
Found while testing out an automated migration tool for #10294.
Looks like switching to
std::formatis indeed worth it for catching such subtle bugs at compile time.cc @Ericson2314, @Mic92
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.