Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nativeBuildInputs for nix-shell #2504

Closed
wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

Now the nix-shell will generate a nix expression that looks like this:

with import <nixpkgs> {};
runCommand "shell" {
  nativeBuildInputs = [
    (...)
    (...)
    (...)
  ];
}

from

$ nix-shell --packages ... ... ...

Fixes the issue described in NixOS/nixpkgs#38657.

Now the nix-shell will generate a nix expression that looks like this:

with import <nixpkgs> {};
runCommand "shell" {
  nativeBuildInputs = [
    (...)
    (...)
    (...)
  ];
}

from

$ nix-shell --packages ... ... ...

Fixes the issue described in NixOS/nixpkgs#38657.
@MrChico
Copy link

MrChico commented Apr 19, 2019

Any chance of this getting some love?

@matthewbauer
Copy link
Member Author

matthewbauer commented Jul 10, 2019

Some cases could also screw this up, however. For instance in some cases you want to treat your dependencies as libraries (for zlib, libsystemd, etc.). For now it is probably safest to leave the behavior as is (with -p implying buildInputs).

@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Jun 2, 2021
@stale
Copy link

stale bot commented Jun 19, 2022

I closed this issue due to inactivity. → More info

@stale stale bot closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants