Revise division of labor in deserialization of derivations #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edolstra This little PR look OK to you? I have a lot of changes I'd like to land so don't want to accumulate too much of a backlog. |
Ericson2314
force-pushed
the
derivation-header-include-order
branch
from
646ec61 to
bcde545
Compare
This further continues with the dependency inverstion. Also I just went ahead and exposed `parseDerivation`: it seems like the more proper building block, and not a bad thing to expose if we are trying to be less wedded to drv files on disk anywas.
Ericson2314
changed the title
|
Renamed because this is now a bit more than merely flipping the dependency. |
Ericson2314
changed the title
Ericson2314
changed the title
Ericson2314
changed the title
Ericson2314
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now:
No
Storemethods are defined inderivations.ccparseDerivationon the underlying string is exposed, since that is the root functionality. (It might be better to make this take an arbitrarystd::istringstreamat some point.)Store::derivationFromPathandStore::readDerivationare defined less redundantly.I think it makes more sense to define the data model (derivations), before the operations (store api).This has already been done by other already-merged PRs.