-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify changing cachix cache for install tests #4577
Conversation
1004a09
to
ef75aa0
Compare
- convert cachix cache name from an env into a secret so it (along with the token/key) can be set once per fork - use CACHIX_AUTH_TOKEN in addition to CACHIX_SIGNING_KEY; it looks like cachix will try signing key first, then auth token.
ef75aa0
to
12ec962
Compare
@domenkozar I've modified this after the initial plan didn't quite work out. I wanted to just move the CACHIX_NAME into the repo secrets so that it'd be easy to set once per fork, but I didn't realize GA would literally prevent it from appearing in the output of a step (which breaks the installerURL). I still think there's ergonomic value in something lower-friction than having to modify the workflow, so I've fallen back on a deterministic CACHIX_NAME (lowercase of |
Seems to work! https://github.com/NixOS/nix/runs/2087652478 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/anyone-up-for-picking-at-some-nix-onboarding-improvements/13152/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/installer-test-suite-small-project-s-high-leverage-help-wanted/13662/1 |
@domenkozar In the process of getting set up to try out the new installer tests that landed in #4549 I noticed a couple of small workflow improvements:
<username>-<repo>-install-tests
(i.e.,abathur-nix-install-tests
)Test runs in my fork for this change:
If adopted, Nix would need a new
nixos-nix-install-tests
cache.