nix-collect-garbage: translate to C++ #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reasoning? Speed? |
|
Cool |
| if (link.find("link") != string::npos) { | ||
| printMsg(lvlInfo, format("removing old generations of profile %1%") % path); | ||
|
|
||
| runProgramSimple(settings.nixBinDir + "/nix-env", Strings{"-p", path, "--delete-generations", gen, dryRun ? "--dry-run" : ""}); |
There was a problem hiding this comment.
Rather than calling nix-env, it would be cleaner to factor out opDeleteGenerations() from nix-env.cc into a library function and call it directly. IMHO that's one of the main benefits of rewriting in C++ (being able to call APIs directly rather than going through command line invocations).
There was a problem hiding this comment.
I'm not yet confident with doing this, can we accept this in the while as a 1:1 translation?
lucabrunox
force-pushed
the
nix-collect-garbage
branch
from
b01477e
to
ab2b3d6
Compare
edolstra
added a commit
that referenced
this pull request
Apr 22, 2015
nix-collect-garbage: translate to C++
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.