Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl usage in install script in sync with instructions #5607

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

kmt-lnh
Copy link

@kmt-lnh kmt-lnh commented Nov 19, 2021

Hi!

This change makes the install script consistent with the installation instructions while keeping wget as an alternative.

Based on the current installation instructions, one starts with invoking curl but the install script gives precedence to wget. It can happen, that curl works on a system, but wget does not. 1 It is very confusing when the install process starts by downloading the script but then the installer script indicates a network error.

In pull request #5096 @AnatoleLucet and @Mic92 introduced support for wget during the installation. In it Anatole suggested changing the installation instructions from the current curl -L https://nixos.org/nix/install | sh to one that's using wget, but this didn't happen. I simply switched the order of the availability checks to ensure that curl comes first.

Footnotes

  1. For example, if the user is behind a proxy and the the environmental variable used is HTTPS_PROXY then curl will work, but wget won't. This is just one example, but as long as curl can work and wgetcan fail these errors can appear and will be confusing.

This change makes the script consistent with the installation
instructions while keeping wget as an alternative.
@edolstra edolstra merged commit 9cd8cff into NixOS:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants