debug #6383 #6484
Closed
debug #6383 #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogti
force-pushed
the
debug-6383
branch
5 times, most recently
from
7a19904 to
0075fa9
Compare
fogti
commented
May 5, 2022
| @@ -988,13 +988,28 @@ void DerivationGoal::resolvedFinished() | |||
| auto resolvedHash = get(resolvedHashes, wantedOutput); | |||
| if ((!initialOutput) || (!resolvedHash)) | |||
| throw Error( | |||
| "derivation '%s' doesn't have expected output '%s' (derivation-goal.cc/resolvedFinished,resolve)", | |||
| "derivation '%s' doesn't have expected output '%s'", | |||
| worker.store.printStorePath(drvPath), wantedOutput); | |||
| auto realisation = get(resolvedResult.builtOutputs, DrvOutput { *resolvedHash, wantedOutput }); | |||
There was a problem hiding this comment.
example failure (reported by @trofi):
error: derivation '/nix/store/g7q24qrdzdcvsirxw8aw0alc9s0qsl77-shared-mime-info-unstable-2021-12-03.drv' doesn't have expected output 'dev @ sha256:094p4p14vbmqhhd2g4nr08phln6hr789rzqnjwll9q79kisc7n7g'
builtOutputs:
out @ sha256:094p4p14vbmqhhd2g4nr08phln6hr789rzqnjwll9q79kisc7n7g (key) = /nix/store/98f30ch5mldzkw0zznx2s2ll6r940jv3-shared-mime-info-unstable-2021-12-03
=> hash matches, but the wanted output is not part of the built outputs.
|
I am a little confused what is going with all the explicit construction; are you thinking what we did before is more unsafe than we think? |
|
Most of the explicit construction is to make sure that strings are still valid when used, and that the types used are correct (the only important cases are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inserts the missing debug output to better diagnose what went wrong in #6383; and fixes a potential use-after-free via
getOr.The main problem is that the error might take a long time to appear, but once it appears is reproducible if the build output is really required (and not just because the output got pulled in by a full build, but is not used by any other derivation)