support building with --enable-gc=no #6741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes fixing the build without boehm.
Fixes #6250.
Would be nice to test this (building without boehm) somehow (in hydra maybe), but haven't looked at that yet and IMO that can be added separately. Could help prevent or reduce regressions on this configuration.
I'm interested in this to possibly make ASAN builds more reliable. Not sure if this will really help, but since I was looking at it anyway and the fixes are low-hanging fruit, I've submitted it 😄 .
Not 100% sure about the AllocCache members, but in the cc file there's a path for both boehm enabled and disabled where the members are needed, so I just assumed that that was correct and this corresponds to that.