fix(libstore): allow Nix to access all Rosetta 2 paths on MacOS #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will need to be backported to 2.10 |
|
Looks like I neglected to open a PR. Thank you @lovesegfault! |
edolstra
added
backport 2.10-maintenance
macos
|
Successfully created backport PR #6819 for |
winterqt
reviewed
Aug 24, 2022
| @@ -98,7 +98,9 @@ | |||
| (allow file* | |||
| (literal "/private/var/select/sh")) | |||
|
|
|||
| ; Allow Rosetta 2 to run x86_64 binaries on aarch64-darwin. | |||
| ; Allow Rosetta 2 to run x86_64 binaries on aarch64-darwin (and vice versa). | |||
There was a problem hiding this comment.
(and vice versa)
Rosetta 2 can't be run on x86_64 systems, maybe this comment should be updated to be more detailed as to what that entails? My only guess is that we want to enable checking if Rosetta is installed on both x86_64 and aarch64, so the comment should probably reflect that.
Minion3665
pushed a commit
to Minion3665/nix
that referenced
this pull request
Feb 23, 2023
fix(libstore): allow Nix to access all Rosetta 2 paths on MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Fixes: #5884
I cherry-picked this from @centromere's tree, hopefully they're alright with
that.
This allows building
nixandcachixon macOS with sandboxing enabled, amongother packages.