Set HOME var to root's home when running nix-store as root
#6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [recent-ish change](NixOS#6676) logs a warning when a potentially counterintuitive situation happens. This now causes the multi-user installer to [emit a warning](NixOS/nixpkgs#189043) when it's doing the "seed the Nix database" step via a low-level `nix-store --load-db` invocation. `nix-store` functionality implementations don't actually use profiles or channels or homedir as far as i can tell. So why are we hitting this code at all? Well, the current command approach for functionality here builds a [fat `nix` binary](https://github.com/NixOS/nix/blob/master/src/nix/local.mk#L23-L26) which has _all_ the functionality of previous individual binaries (nix-env, nix-store, etc) bundled in, then [uses the invocation name](https://github.com/NixOS/nix/blob/master/src/nix/main.cc#L274-L277) to select the set of commands to expose. `nix` itself has this behavior, even when just trying to parse the (sub)command and arguments: ``` dave @ davembp2 $ nix error: no subcommand specified Try 'nix --help' for more information. dave @ davembp2 $ sudo nix warning: $HOME ('/Users/dave') is not owned by you, falling back to the one defined in the 'passwd' file error: no subcommand specified Try 'nix --help' for more information. dave @ davembp2 $ HOME=~root sudo nix error: no subcommand specified Try 'nix --help' for more information. ``` This behavior can also be seen pretty easily with an arbitrary `nix-store` invocation: ``` dave @ davembp2 $ nix-store --realize dave @ davembp2 $ sudo nix-store --realize # what installer is doing now warning: $HOME ('/Users/dave') is not owned by you, falling back to the one defined in the 'passwd' file dave @ davembp2 $ sudo HOME=~root nix-store --realize # what this PR effectively does dave @ davembp2 $ ```
|
Fixes NixOS/nixpkgs#189043 |
samuela
approved these changes
Sep 1, 2022
thufschmitt
approved these changes
Sep 5, 2022
Minion3665
pushed a commit
to Minion3665/nix
that referenced
this pull request
Feb 23, 2023
Set `HOME` var to `root`'s home when running `nix-store` as `root`
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-install-script-not-allowed-to-set-env-variables/26104/2 |
|
Agreed |
|
@virusdave Check out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent-ish change logs a warning when a potentially counterintuitive situation happens.
This now causes the multi-user installer to emit a warning when it's doing
the "seed the Nix database" step via a low-level
nix-store --load-dbinvocation.nix-storefunctionality implementations don't actually use profiles or channels or homedir as far as i can tell. So why are wehitting this code at all?
Well, the current command approach for functionality here builds a fat
nixbinary which has all the functionality ofprevious individual binaries (nix-env, nix-store, etc) bundled in, then uses the invocation name to select the
set of commands to expose.
nixitself has this behavior, even when just trying to parse the (sub)command and arguments:This behavior can also be seen pretty easily with an arbitrary
nix-storeinvocation: