check the store for input before failing (hopefully fix #6383) #7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay this should be cleaner. It took a while because I was running into errors testing this, but it turns out they were unrelated and I just had to do some combination of |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-41/23848/1 |
|
@thufschmitt I fixed the problems we discussed about this PR. Care to take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same basic idea as #6572 and #7390, but applied to the problem occurring in #6383.
I am not super familiar with the ++ part of C++, so some things that I'm not sure about:
I have a
std::shared_ptrthat I'm turning into a regular pointer with.get(). The only thing happening with this pointer is accessing / copying values shortly thereafter. Is this safe? What is the canonical way of doing this?I had to change
autotoconst Realisation *because otherwise it was defaulting to a regularRealisation *and then failing later when it needed to beconst. I'm not sure if this is the idiomatic way of dealing with this problem.