Improve warning when an untrusted user is using an untrusted substituter #7461
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-would-you-like-to-see-improved-in-nix-cli-experience/24012/1 |
|
Rather than having a long warning message, it might be better to link to some section in the manual. |
Or go the route of the rustc compiler, in which you get a short message, and a link to a long explanation. |
rapenne-s
force-pushed
the
improve_messaging_untrusted_sub_user
branch
from
e94b26d to
4303db8
Compare
|
I'm convinced it's important to get immediate information, that doesn't even require Internet or a web browser to read, I think we could add a link to an deeper explanation (if we had it), but we should keep a local explanation. |
rapenne-s
force-pushed
the
improve_messaging_untrusted_sub_user
branch
from
4303db8 to
08eb59e
Compare
|
@fricklerhandwerk I made the changes, however I don't know if we want to make a standardized wording to refer to documentation. I don't think we have any at the moment, but it would be practical for further similar changes. |
rapenne-s
force-pushed
the
improve_messaging_untrusted_sub_user
branch
2 times, most recently
from
8de4a59 to
5ac9a41
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-42/24204/1 |
thufschmitt
added
error-messages
rapenne-s
force-pushed
the
improve_messaging_untrusted_sub_user
branch
from
3fc30a0 to
f6d1e96
Compare
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
rapenne-s
force-pushed
the
improve_messaging_untrusted_sub_user
branch
from
f6d1e96 to
aa61ae0
Compare
Co-authored-by: Théophane Hufschmitt <theophane.hufschmitt@tweag.io>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-43/25185/1 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-team-report-2022-10-2023-03/27486/1 |
This change brings a huge warning message with explanations when
an untrusted user (wrt nix) is trying to use a substituter that isn't
trusted in nix.conf, this is a very common case nowadays with flakes
containing substituter informations.
The point is to help the user by giving the following information:
fix #6672
Release Notes
Does it deserve an entry in release notes?
Testing
All the tests are still passing.
Priorities
Add 👍 to pull requests you find important.