Stuctured command stability #7611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
fricklerhandwerk,
edolstra and
thufschmitt
as code owners
|
The diff is quite large and it's not clear at a glance what the change actually is about. Can you elaborate in the PR description what exactly changed in terms of user-visible behavior? This seems more fitting:
PS: "Clean up" should be a forbidden phrase in commit messages. |
|
🎉 All dependencies have been resolved ! |
|
The diff is large because of the other PRs this depends on. |
|
Draft because https://github.com/apps/dpulls is not cutting it, and the chained diffs are confusing. |
github-actions
bot
added
documentation
with-tests
Ericson2314
force-pushed
the
structured-command-stabilization
branch
from
b16d91f to
913888f
Compare
github-actions
bot
removed
the
with-tests
|
Discussed in the Nix team meeting 2023-04-03:
|
Ericson2314
force-pushed
the
structured-command-stabilization
branch
from
913888f to
e97c91f
Compare
github-actions
bot
added
with-tests
|
This is now just the infrastructure, as discussed. |
Ericson2314
force-pushed
the
structured-command-stabilization
branch
from
e97c91f to
1a71eca
Compare
roberth
approved these changes
Apr 3, 2023
Ericson2314
force-pushed
the
structured-command-stabilization
branch
from
1a71eca to
3c059ce
Compare
Prior to this, there was an ad-hoc whitelist in `main.cc`. Now, every command states its stability. In a future PR, we will adjust the manual to take advantage of this new information in the JSON. (It will be easier to do that once we have some experimental feature docs to link too; see NixOS#5930 and NixOS#7798.)
Ericson2314
force-pushed
the
structured-command-stabilization
branch
from
3c059ce to
4a0b893
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-04-03-nix-team-meeting-minutes-46/27008/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, there was an ad-hoc whitelist in
main.cc. Now, every command states its stability.In a future PR, we will adjust the manual to take advantage of this new
information in the JSON. It will be easier to do that once we have some experimental feature docs to link too; see #5930 and #7798.)