Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stratify ExtraPathInfo along Installable hierarchy #7763

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Feb 6, 2023

Motivation

Instead of having a bunch of optional fields, have a few subclasses which can have mandatory fields.

Additionally, the new getExtraPathInfo, and nixpkgsFlakeRef, are moved to InstallableValue.

Also, add a bunch of doc comments for sake of the internal API docs.

Context

I did this because NixOS/rfcs#134 ; with these things moved to InstallableValue, the base Installable no longer depends on libexpr! This is a major step towards that.

Depends on #7757

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

@Ericson2314 Ericson2314 marked this pull request as draft February 6, 2023 16:42
@Ericson2314 Ericson2314 changed the title Associate each derivation with a single ExtraPathInfo Associate each installable with a single ExtraPathInfo Feb 14, 2023
@Ericson2314 Ericson2314 mentioned this pull request Feb 20, 2023
10 tasks
@Ericson2314 Ericson2314 force-pushed the installable-wide-info branch from ee161ec to 9160e5c Compare February 21, 2023 15:59
@Ericson2314 Ericson2314 force-pushed the installable-wide-info branch 2 times, most recently from 521e043 to 52e0ab7 Compare March 17, 2023 00:07
@Ericson2314 Ericson2314 added the RFC Related to an accepted RFC label Mar 17, 2023
@dpulls
Copy link

dpulls bot commented Mar 24, 2023

🎉 All dependencies have been resolved !

@Ericson2314 Ericson2314 changed the base branch from master to 0.5-release March 24, 2023 13:08
@Ericson2314 Ericson2314 changed the base branch from 0.5-release to master March 24, 2023 13:08
@Ericson2314 Ericson2314 marked this pull request as ready for review March 24, 2023 13:09
@Ericson2314 Ericson2314 force-pushed the installable-wide-info branch from 52e0ab7 to cf8d487 Compare March 24, 2023 15:36
Instead of having a bunch of optional fields, have a few subclasses
which can have mandatory fields.

Additionally, the new `getExtraPathInfo`, and `nixpkgsFlakeRef`, are
moved to `InstallableValue`.

I did these things because NixOS/rfcs#134 ; with
these things moved to `InstallableValue`, the base `Installable` no
longer depends on libexpr! This is a major step towards that.

Also, add a bunch of doc comments for sake of the internal API docs.
@Ericson2314 Ericson2314 force-pushed the installable-wide-info branch from cf8d487 to 256f3e3 Compare March 24, 2023 16:24
@Ericson2314 Ericson2314 changed the title Associate each installable with a single ExtraPathInfo Stratify ExtraPathInfo along Installable hierarchy Mar 25, 2023
@edolstra edolstra merged commit 5e3f855 into NixOS:master Mar 27, 2023
@Ericson2314 Ericson2314 deleted the installable-wide-info branch March 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Related to an accepted RFC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants