Stratify ExtraPathInfo
along Installable
hierarchy
#7763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of having a bunch of optional fields, have a few subclasses which can have mandatory fields.
Additionally, the new
getExtraPathInfo
, andnixpkgsFlakeRef
, are moved toInstallableValue
.Also, add a bunch of doc comments for sake of the internal API docs.
Context
I did this because NixOS/rfcs#134 ; with these things moved to
InstallableValue
, the baseInstallable
no longer depends on libexpr! This is a major step towards that.Depends on #7757Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*