doc: Document Boehm GC patch in Prerequisites #7902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be possible to use the workaround in #7725 also if the patch is not present on linux (we could add a #define in the patch to check that). Not sure if we want that. |
| `--enable-gc` to `configure`. | ||
| `--enable-gc` to `configure`. Nix relies on a patch to support the | ||
| necessary interactions between coroutines and the collector; please | ||
| apply `boehmgc-coroutine-sp-fallback.diff` to your Boehm garbage collector |
There was a problem hiding this comment.
Please add a link to the file on GitHub so people can find out what specifically you mean.
This is the same issue as #7412 (comment).
I would prefer this. I'll review #7725 instead. @yorickvP perhaps we should treat the gc as unpatched by default and have an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix GC-related crashes for some people who build from source. Poor souls.
Context
The patch is still needed.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*