Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: restore binary-dist artifact to Hydra static builds #7946

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Mar 2, 2023

Motivation

It looks like this was lost in #6538.

Context

Some third-parties depend on being able to get the static binary-dist artifact (namely, Renovate, as noticed by Amanda on Matrix).

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

I feel like I say this a lot recently, but it would be swell if this could get backported to 2.14 as well... 😅

@cole-h cole-h requested a review from edolstra as a code owner March 2, 2023 18:04
@edolstra edolstra merged commit 19c1a46 into NixOS:master Mar 3, 2023
@cole-h cole-h deleted the restore-static-bin-dist branch March 3, 2023 15:05
@AmandaCameron
Copy link

Can this be backported to 2.14? It seems that the tool is downloaded ultimately via this line of code so I'm guessing a point release will be necessary for it to ultimately be working again, but I'm not overly familiar with the nix release process

@Ericson2314
Copy link
Member

Good call.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Successfully created backport PR for 2.14-maintenance:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants