Ressurect tests for GC+coroutines #8204
Open
+148
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
|
cc @thufschmitt |
edolstra
reviewed
Apr 11, 2023
|
|
||
| // Generate 2 objects, discard one, run gc, | ||
| // see if one got collected and the other didn't | ||
| // GC is disabled inside coroutines on __APPLE__ |
There was a problem hiding this comment.
I think this kind of test is inherently unreliable, particularly the part where it checks that an object got collected. Since Boehm is a conservative collector, you can never be certain that no pointer to an object survives. For instance, you can't really count on an assignment like do_collect = nullptr; not being optimized away.
There was a problem hiding this comment.
You could increase the odds by allocating a large number of individual objects.
If none of them gets collected, we probably have a significant GC issue anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Redo #7725. GC mostly happens on a best-effort basis, and is sensitive to compilation. This was failing on musl and x86.
Change the relevant assertions to
EXPECT_, causing them to just print a warning instead of failing the test.Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.