Upload the Hydra eval id for releases #8464
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of Nix outputting Nixpkgs'
nix-fallback-paths.nix
file, requiring the person to do the release to commit it to Nixpkgs, have it upload a file containing the Hydra evaluation id.This has these advantages:
nix-fallback-paths.nix
without having to change anything on the Nix sideContext
In NixOS/nixpkgs#233439 I wanted to update the stable Nix version in Nixpkgs, which apparently requires updating the
nix-fallback-paths.nix
. In that PR, a user provided anix-fallback-paths.nix
to use, but I had to jump through hoops to verify that those paths are actually correct.Because of this I opened NixOS/nixpkgs#235463 in order to automatically generate an up-to-date
nix-fallback-paths.nix
in Nixpkgs. However that script needs the Hydra evaluation ID as an input to work. Unfortunately the Nix release script does not expose the evaluation ID, therefore requiring guessing of it.Because of this @edolstra added support for the
nix-fallback-paths.nix
to be uploaded to releases.nixos.org (in non-master branch for now, this commit), which is now the case for 2.16.1.However this only marginally improves the issue, see above motivation. This PR suggests a better way of doing this in response to that.
This work is sponsored by Antithesis ✨
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.