Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-User fail if already has /nix #8673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DynamicApproach
Copy link

Motivation

If a user has already initiated and installed Nix as a single user, we should make sure they remove config files before attempting to install the multi-user variant.

Context

Rather than letting people double up on files, we should warn them to remove old files first.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@abathur
Copy link
Member

abathur commented Jul 13, 2023

  • This instruction won't work at all on macOS.
  • Halting on the presence of /nix would also directly conflict with the effort to partially restore idempotence in Make multi-user installer idempotent #7603 (though I'm not sure if that effort will succeed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants