Only add Nix paths to $PATH if not already in there #9297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure it's documented, but my interpretation is that both of these profile scripts are intended to be POSIX sh. IIRC I have a draft PR open that uses
It isn't a given that my PR will move ahead at all, so it's fine with me if you'd like to try to cherry-pick that bit and land it in this PR. |
When people source the Nix profile scripts more than once, they can cause appended PATH variables to grow longer each time. This is somewhat benign, but it does spook people and cause support load. (cherry picked from commit cc5db08)
kra-mo
force-pushed
the
fix-path-duplicates
branch
from
92110c2
to
da701ca
Compare
|
Thanks, I cherry-picked that commit instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes the paths being added multiple times if the user logs out and back in
Add 👍 to pull requests you find important.