-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract reference documentation on remote builds #9526
extract reference documentation on remote builds #9526
Conversation
acee315
to
8ffd5de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way of rendering these changes locally, reading the diff github produces is a bit hard, I would gladly help reviewing this.
No, unfortunately still, you have to go through the whole build process locally to produce a rendering. Run |
8ffd5de
to
3b7c593
Compare
- move all reference documentation to the `builders` configuration setting - reword documentation on machine specification, add examples - disable showing the default value, as it rendered as `@/dummy/machines`, which is wrong - highlight the examples - link to the configuration docs for distributed builds - builder -> build machine
e36f6eb
to
ed3a26c
Compare
The speed factor changed from |
Motivation
#9202 (comment)
Context
This is a large diff, but in essence it does this:
builders
configuration setting@/dummy/machines
, which is wrongThis work is sponsored by Antithesis ✨
Priorities
Add 👍 to pull requests you find important.