Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't touch files if they don't need changing #133

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

piegamesde
Copy link
Member

Fixes #88

This has not been tested yet, CC @SebTM please take a look

@SebTM
Copy link

SebTM commented Sep 26, 2023

Thanks very much for looking into this as fast as you did 🚀
Works well, tested it as following:

Modified mtime of flake.nix via touch -mt 0911171533 flake.nix and ran new build of nixfmt:

-rw-r--r-- 1 sebtm users  3330 Nov 17  2009 flake.nix
dist-newstyle/build/x86_64-linux/ghc-9.0.2/nixfmt-0.5.0/x/nixfmt/build/nixfmt/nixfmt flake.nix
-rw-r--r-- 1 sebtm users  3330 Nov 17  2009 flake.nix

running afterwards my old install of nixfmt results in:

-rw-r--r-- 1 sebtm users  3330 Nov 17  2009 flake.nix
nixfmt flake.nix
-rw-r--r-- 1 sebtm users  3330 Sep 26 02:15 flake.nix

which demonstrates the difference again :) so LGTM

main/Main.hs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@infinisil
Copy link
Member

I'd merge, but can't because CI doesn't seem to run

@piegamesde
Copy link
Member Author

CI doesn't seem to be running, I have no idea what's happening there. I could probably manually merge and push to master, but that would be undesirable. The CI is broken in #132 too btw

@Lucus16
Copy link
Contributor

Lucus16 commented Oct 5, 2023

We'll need to get #134 merged for CI to work. If you don't want to wait for it, just run CI locally and then merge to master manually.

@infinisil infinisil merged commit 6e6385f into master Oct 9, 2023
2 checks passed
@infinisil infinisil deleted the piegames/fix-mtime branch October 9, 2023 19:09
0x4A6F added a commit to 0x4A6F/nixpkgs that referenced this pull request Mar 8, 2024
dasJ added a commit to NixOS/nixpkgs that referenced this pull request Mar 11, 2024
jian-lin pushed a commit to linj-fork/nixpkgs that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numtide/treefmt compatibility
4 participants