Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault Integration for Secrets #1289

Open
grahamc opened this issue Apr 20, 2020 · 5 comments
Open

Vault Integration for Secrets #1289

grahamc opened this issue Apr 20, 2020 · 5 comments
Milestone

Comments

@grahamc
Copy link
Member

grahamc commented Apr 20, 2020

Two things to consider:

  1. A way for Vault to provide deployment.keys secrets
  2. A way for Vault to provide tokens for nixops-aws and other plugins, instead of reading from the environment.

We should consider if we want to do these at all, and also if we should make its behavior something a plugin could provide.

@grahamc grahamc added this to the 2.0 milestone Apr 20, 2020
@Mic92
Copy link
Member

Mic92 commented Jul 24, 2020

This project might be relevant as well: https://github.com/Mic92/sops-nix
Sops has vault integration to decrypt keys.

@roberth
Copy link
Member

roberth commented Sep 16, 2021

This could be split up into two changes, one to define the whole network via the module system, the other to add a resource similar to commandOutput, but which doesn't store a value in the state file.
Using these two, this can be implemented completely in Nix, at least for (1).
For (2) this may require plugins to provide thunks, so a tight integration with the interpreter, which is not possible with nix-instantiate. Writing a python binding for libexpr may be out of scope here, but you can chat with me about libexpr bindings though :)

@tewfik-ghariani
Copy link
Contributor

Would https://github.com/PsyanticY/nixops-vault be somehow helpful?

@roberth
Copy link
Member

roberth commented Sep 28, 2021

This issue is mostly about getting secrets out of Vault at deployment time, whereas nixops-vault currently only supports the creation of resources inside vault; writing to vault. I suppose it could add support for a secret reading resource, which will enable (1), but perhaps not (2) just yet.

@roberth
Copy link
Member

roberth commented Sep 28, 2021

That said, (1) is probably not what you want anyway. Vault Agent templating would be preferable in most setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants