Always provide our known_hosts in addition to user known_hosts #1464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves one of the problems from #1264 (comment)
It also solves a problem where multiple deployments to distinct private networks fight over the key for the same ip that occurs in both.
Prevously, you'd
With this pr, we don't have to rely on user configuration to include
known_hosts entries for the deployments.
It makes
nixops import --include-keys
unnecessary, unless youuse those entries outside of nixops.
Since recently we can get our deployment state from remote storage
backends, but we didn't have a way to get configure the known_hosts
yet. This is now largely unnecessary.
This functionality requires some cooperation from the plugins. For
instance, here's what ec2 needs to do: (pun intended)
(NixOS/nixops-aws#141)