-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurations for nvidia microarchitectures #1094
Conversation
flake.nix
Outdated
common-gpu-nvidia-ada-lovelace = import ./common/gpu/nvidia/ada-lovelace; | ||
common-gpu-nvidia-ampere = import ./common/gpu/nvidia/ampere; | ||
common-gpu-nvidia-turing = import ./common/gpu/nvidia/turing; | ||
common-gpu-nvidia-pascal = import ./common/gpu/nvidia/pascal; | ||
common-gpu-nvidia-maxwell = import ./common/gpu/nvidia/maxwell; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this a public api, would work against #992 a bit. Progress on that has been slow, but we made good progress on https://github.com/numtide/nixos-facter so I would prefer to not expose stuff in the flake.nix, which we later on want to deprecate again. The alternative would be to make this part of NixOS as well...
With that we could than automatically detect what nvidia generation is installed in a machine.
I have a small question about this, |
It's difficult the way this was implemented in nixpkgs to have such an error message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the Pascal dependency to the XPS 9560 while we are at it?
I suggest we add the architecture to each model that uses nvidia before this is merged |
I think this might be a lot of work for a single person. This is better parallelized after merging. |
we don't want to increase the api further.
True, I can take a look at affected modules once this is merged. |
here is a checklist: #1100 |
And add logic to enable the opensource drivers if the NVIDIA driver package and micro architecture supports it
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input