-
-
Notifications
You must be signed in to change notification settings - Fork 831
microsoft/surface: add patch to handle newer rust versions #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
microsoft/surface: add patch to handle newer rust versions #1690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing this from my Surface 3 Pro running kernel 6.15.9 using this nixos-hardware patch.
|
Can also confirm on the Surface Go running kernel 6.15.9 |
|
I've set my input like so, output from `nix log`If I set Didn't get a chance to boot yet, let me know if I'm doing something wrong as I'm fairly new to nix. |
Please try |
I think I'm getting same error but here is the output just in case: output from `nix log` |
|
same problem with surface 5 and kernel 6.12 |
This reverts commit ff87202.
|
Edit: I got it to build by just disabling Rust altogether. Probably not the most elegant solution, but it does build 😅 Hey all, thanks for the reports. To be honest, I have no idea how to address this for 6.12, but I'll do what I can to get it building before I mark this as ready. If anyone has any suggestions, please let me know! |
2ae8fda to
f7de836
Compare
f7de836 to
e580e56
Compare
I am now able to compile both |
Description of changes
Adds a patch for older kernel versions so they can build using Rust 1.91, which is used in NixOS 25.11. This fixes a build error and #1685.
Update: Due to a cryptic build error, Rust is disabled for the 6.12 (
longterm) kernel. It can be re-enabled for the next LTS kernel (6.18).Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input