Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value for services.hardware.openrgb.motherboard #709

Closed
wants to merge 1 commit into from

Conversation

lucasew
Copy link

@lucasew lucasew commented Aug 31, 2023

Description of changes

With this PR if something references the common processor module so that OpenRGB works out of the box if enabled.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

Signed-off-by: lucasew <lucas59356@gmail.com>
@lucasew lucasew changed the title default value for hardware.openrgb.motherboard default value for service.hardware.openrgb.motherboard Aug 31, 2023
@lucasew lucasew changed the title default value for service.hardware.openrgb.motherboard default value for services.hardware.openrgb.motherboard Aug 31, 2023
@lucasew
Copy link
Author

lucasew commented Aug 31, 2023

Tested
image

@Mic92
Copy link
Member

Mic92 commented Sep 3, 2023

Since this is a bit of a niche application, what do you think about inverting the control and set it in the openrbg module instead? NixOS/nixpkgs#253048

@lucasew
Copy link
Author

lucasew commented Sep 3, 2023

Since this is a bit of a niche application, what do you think about inverting the control and set it in the openrbg module instead? NixOS/nixpkgs#253048

Awesome idea.

@lucasew lucasew closed this Sep 3, 2023
@lucasew lucasew deleted the openrgb-defaults branch September 3, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants