Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my erosanix flake #443

Closed
wants to merge 1 commit into from
Closed

Add my erosanix flake #443

wants to merge 1 commit into from

Conversation

emmanuelrosa
Copy link

No description provided.

@ysndr
Copy link
Member

ysndr commented Mar 16, 2022

Hej

thanks for your submission.
Be aware that your module needs some changes.
Please check your flake with the command in the readme.

@emmanuelrosa
Copy link
Author

I found the issue. It's fixed now.

@garbas
Copy link
Member

garbas commented Apr 7, 2022

I still get the error when running flake-info flake github:mmanuelrosa/erosanix.

@emmanuelrosa Could you look at it?

@emmanuelrosa
Copy link
Author

I got a successful run of flake-info after fixing the issue. It looks like the checks failed due to some other repos.

@ncfavier
Copy link
Member

ncfavier commented Apr 8, 2022

Note that you didn't need to change the default, only to give it a textual representation for the manual: defaultText = lib.literalExpression "pkgs.electrs". (We should probably document this in the README as it seems like the most common reason that flake-info fails)

@emmanuelrosa
Copy link
Author

OK, I went ahead and made the suggested change.

I noticed that flake-info is quite picky. For example, if the flake path is ".", meaning current directory, it complains about a syntax error, which really confused me because I thought there was a problem with the Nix code. If the path to the flake ends with a forward slash it also complains, but that error is clear.

@ncfavier
Copy link
Member

ncfavier commented Apr 8, 2022

Yeah that's fixed in #460

@ncfavier
Copy link
Member

ncfavier commented Apr 8, 2022

Hm actually it still complains about . not being an absolute path. That's annoying. Apparently a problem with nix.

@ysndr
Copy link
Member

ysndr commented Apr 11, 2022

Hm actually it still complains about . not being an absolute path. That's annoying. Apparently a problem with nix.

Yes it needs a ./. I think, since the argument is passed to builtins.getFlake (toString flake); which needs an absolute path.
however nix turns ./. into an absolute path while failing to interpret ..

@ncfavier
Copy link
Member

Ah, but #460 uses --argstr so ./. wouldn't work anymore. I guess that's not a worthy trade-off if the only point of using --argstr is to be able to use registry references.

Another solution might be to pass in the flake reference using --override-flake.

@ysndr
Copy link
Member

ysndr commented Apr 11, 2022

Another solution might be to pass in the flake reference using --override-flake.

.. and model flake-info.nix as a flake?
otherwise I'm not sure where it would pick that overridden flake from?

@ncfavier
Copy link
Member

Just builtins.getFlake "input-flake" (see the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants