-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "sddm: propagate qtbase input"
This reverts commit 40db638. Despite testing this in QEMU on my own machine, it breaks SDDM for everyone else.
- Loading branch information
Showing
1 changed file
with
3 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
056db1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to generally follow my failure from #24133 (comment) -- if Qt parts are installed into system closure it breaks things.
056db1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That didn't install anything into the system environment. In fact, reverting it partially unwrapped SDDM, which means now it requires dependencies from the system environment. I believe this also breaks the Plasma theme, but I can't test that automatically.
056db1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was confused by
propagatedUserEnvPkgs
but I see now that it's not its conventional usage.