Skip to content

Commit

Permalink
python3Packages.sentry-sdk: fix trytond dependency
Browse files Browse the repository at this point in the history
Tryton is an optional dependency, if it is present, Sentry can integrate
it, but when it is not present, Sentry should not pull it in as a
propagated build input, it is only required for the tests that test this
specific integration.

In particular, pulling in trytond creates a transitive dependency on
simplejson, which makes "requests" behave differently in a way that can
break error handling.
  • Loading branch information
ruuda authored and Jon committed Jul 28, 2020
1 parent c3f8d59 commit 302aed5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/sentry-sdk/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ buildPythonPackage rec {
sha256 = "0e5e947d0f7a969314aa23669a94a9712be5a688ff069ff7b9fc36c66adc160c";
};

checkInputs = [ django flask tornado bottle rq falcon sqlalchemy werkzeug ]
checkInputs = [ django flask tornado bottle rq falcon sqlalchemy werkzeug trytond ]
++ stdenv.lib.optionals isPy3k [ celery pyramid sanic aiohttp ];

propagatedBuildInputs = [ urllib3 certifi trytond ];
propagatedBuildInputs = [ urllib3 certifi ];

meta = with stdenv.lib; {
homepage = "https://github.com/getsentry/sentry-python";
Expand Down

0 comments on commit 302aed5

Please sign in to comment.