Skip to content

Commit

Permalink
handbrake: disable sdl2 in custom ffmpeg
Browse files Browse the repository at this point in the history 
Fixes #211297
  • Loading branch information
@Atemu
Atemu committed Jan 27, 2023
1 parent 89d172b commit 79466c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/applications/video/handbrake/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ let
# patches are required for subtitle timing to work correctly. See:
# https://github.com/HandBrake/HandBrake/issues/4029
ffmpeg-version = "4.4.1";
ffmpeg-hb = ffmpeg-full.overrideAttrs (old: {
ffmpeg-hb = (ffmpeg-full.override { withSdl2 = false; }).overrideAttrs (old: {
version = ffmpeg-version;
src = fetchurl {
url = "https://www.ffmpeg.org/releases/ffmpeg-${ffmpeg-version}.tar.bz2";
Expand Down

2 comments on commit 79466c4

@vcunat
Copy link
Member

@vcunat vcunat commented on 79466c4 Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, well, I suppose this was obsoleted by PR #212306, so I chose that one during conflict resolution in 1e42908
It should still build; I tried with some of unrelated changes reverted (e.g. openssl).

@Atemu
Copy link
Member Author

@Atemu Atemu commented on 79466c4 Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please sign in to comment.