Skip to content

Commit

Permalink
Merge #182618: GNOME 42 → 43
Browse files Browse the repository at this point in the history
  • Loading branch information
vcunat committed Oct 13, 2022
2 parents d618530 + 81e445e commit 7a94322
Show file tree
Hide file tree
Showing 205 changed files with 2,583 additions and 1,557 deletions.
7 changes: 7 additions & 0 deletions nixos/doc/manual/from_md/release-notes/rl-2211.section.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
has the following highlights:
</para>
<itemizedlist>
<listitem>
<para>
GNOME has been upgraded to 43. Please take a look at their
<link xlink:href="https://release.gnome.org/43/">Release
Notes</link> for details.
</para>
</listitem>
<listitem>
<para>
During cross-compilation, tests are now executed if the test
Expand Down
3 changes: 3 additions & 0 deletions nixos/doc/manual/release-notes/rl-2211.section.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Support is planned until the end of June 2023, handing over to 23.05.

In addition to numerous new and upgraded packages, this release has the following highlights:

- GNOME has been upgraded to 43. Please take a look at their [Release
Notes](https://release.gnome.org/43/) for details.

- During cross-compilation, tests are now executed if the test suite can be executed
by the build platform. This is the case when doing “native” cross-compilation
where the build and host platforms are largely the same, but the nixpkgs' cross
Expand Down
2 changes: 1 addition & 1 deletion nixos/modules/module-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,9 @@
./services/desktops/pipewire/pipewire-media-session.nix
./services/desktops/pipewire/wireplumber.nix
./services/desktops/gnome/at-spi2-core.nix
./services/desktops/gnome/chrome-gnome-shell.nix
./services/desktops/gnome/evolution-data-server.nix
./services/desktops/gnome/glib-networking.nix
./services/desktops/gnome/gnome-browser-connector.nix
./services/desktops/gnome/gnome-initial-setup.nix
./services/desktops/gnome/gnome-keyring.nix
./services/desktops/gnome/gnome-online-accounts.nix
Expand Down
41 changes: 0 additions & 41 deletions nixos/modules/services/desktops/gnome/chrome-gnome-shell.nix

This file was deleted.

47 changes: 47 additions & 0 deletions nixos/modules/services/desktops/gnome/gnome-browser-connector.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{ config, lib, pkgs, ... }:

let
inherit (lib) mdDoc mkEnableOption mkIf mkRenamedOptionModule teams;
in

{
meta = {
maintainers = teams.gnome.members;
};

imports = [
# Added 2021-05-07
(mkRenamedOptionModule
[ "services" "gnome3" "chrome-gnome-shell" "enable" ]
[ "services" "gnome" "gnome-browser-connector" "enable" ]
)
# Added 2022-07-25
(mkRenamedOptionModule
[ "services" "gnome" "chrome-gnome-shell" "enable" ]
[ "services" "gnome" "gnome-browser-connector" "enable" ]
)
];

options = {
services.gnome.gnome-browser-connector.enable = mkEnableOption (mdDoc ''
Native host connector for the GNOME Shell browser extension, a DBus service
allowing to install GNOME Shell extensions from a web browser.
'');
};

config = mkIf config.services.gnome.gnome-browser-connector.enable {
environment.etc = {
"chromium/native-messaging-hosts/org.gnome.browser_connector.json".source = "${pkgs.gnome-browser-connector}/etc/chromium/native-messaging-hosts/org.gnome.browser_connector.json";
"opt/chrome/native-messaging-hosts/org.gnome.browser_connector.json".source = "${pkgs.gnome-browser-connector}/etc/opt/chrome/native-messaging-hosts/org.gnome.browser_connector.json";
# Legacy paths.
"chromium/native-messaging-hosts/org.gnome.chrome_gnome_shell.json".source = "${pkgs.gnome-browser-connector}/etc/chromium/native-messaging-hosts/org.gnome.chrome_gnome_shell.json";
"opt/chrome/native-messaging-hosts/org.gnome.chrome_gnome_shell.json".source = "${pkgs.gnome-browser-connector}/etc/opt/chrome/native-messaging-hosts/org.gnome.chrome_gnome_shell.json";
};

environment.systemPackages = [ pkgs.gnome-browser-connector ];

services.dbus.packages = [ pkgs.gnome-browser-connector ];

nixpkgs.config.firefox.enableGnomeExtensions = true;
};
}
4 changes: 2 additions & 2 deletions nixos/modules/services/x11/desktop-managers/gnome.nix
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,8 @@ in
++ utils.removePackagesByName optionalPackages config.environment.gnome.excludePackages;

services.colord.enable = mkDefault true;
services.gnome.chrome-gnome-shell.enable = mkDefault true;
services.gnome.glib-networking.enable = true;
services.gnome.gnome-browser-connector.enable = mkDefault true;
services.gnome.gnome-initial-setup.enable = mkDefault true;
services.gnome.gnome-remote-desktop.enable = mkDefault true;
services.gnome.gnome-settings-daemon.enable = true;
Expand Down Expand Up @@ -520,7 +520,7 @@ in

# Let nautilus find extensions
# TODO: Create nautilus-with-extensions package
environment.sessionVariables.NAUTILUS_EXTENSION_DIR = "${config.system.path}/lib/nautilus/extensions-3.0";
environment.sessionVariables.NAUTILUS_4_EXTENSION_DIR = "${config.system.path}/lib/nautilus/extensions-4";

# Override default mimeapps for nautilus
environment.sessionVariables.XDG_DATA_DIRS = [ "${mimeAppsList}/share" ];
Expand Down
2 changes: 1 addition & 1 deletion nixos/modules/services/x11/desktop-managers/pantheon.nix
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ in
elementary-music
elementary-photos
elementary-screenshot
elementary-tasks
# elementary-tasks
elementary-terminal
elementary-videos
epiphany
Expand Down
1 change: 0 additions & 1 deletion nixos/tests/installed-tests/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ in
json-glib = callInstalledTest ./json-glib.nix {};
ibus = callInstalledTest ./ibus.nix {};
libgdata = callInstalledTest ./libgdata.nix {};
librsvg = callInstalledTest ./librsvg.nix {};
glib-testing = callInstalledTest ./glib-testing.nix {};
libjcat = callInstalledTest ./libjcat.nix {};
libxmlb = callInstalledTest ./libxmlb.nix {};
Expand Down
9 changes: 0 additions & 9 deletions nixos/tests/installed-tests/librsvg.nix

This file was deleted.

79 changes: 51 additions & 28 deletions pkgs/applications/editors/gnome-builder/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,92 +2,113 @@
, lib
, ctags
, cmark
, appstream-glib
, desktop-file-utils
, editorconfig-core-c
, fetchurl
, fetchpatch
, flatpak
, gnome
, libgit2-glib
, gi-docgen
, gobject-introspection
, glade
, gspell
, gtk3
, gtksourceview4
, enchant
, icu
, gtk4
, gtksourceview5
, json-glib
, jsonrpc-glib
, libdazzle
, libhandy
, libadwaita
, libpanel
, libpeas
, libportal-gtk3
, libportal-gtk4
, libxml2
, meson
, ninja
, ostree
, pcre
, d-spy
, pcre2
, pkg-config
, python3
, sysprof
, template-glib
, vala
, vte
, webkitgtk
, wrapGAppsHook
, vte-gtk4
, webkitgtk_5_0
, wrapGAppsHook4
, dbus
, xvfb-run
}:

stdenv.mkDerivation rec {
pname = "gnome-builder";
version = "42.1";
version = "43.2";

outputs = [ "out" "devdoc" ];

src = fetchurl {
url = "mirror://gnome/sources/${pname}/${lib.versions.major version}/${pname}-${version}.tar.xz";
sha256 = "XU1RtwKGW0gBcgHwxgfiSifXIDGo9ciNT86HW1VFZwo=";
sha256 = "dzIhF6ERsnR7zOitYFeKZ5wgIeSGkRz29OY0FjKKuzM=";
};

patches = [
# The test environment hardcodes `GI_TYPELIB_PATH` environment variable to direct dependencies of libide & co.
# https://gitlab.gnome.org/GNOME/gnome-builder/-/commit/2ce510b0ec0518c29427a29b386bb2ac1a121edf
# https://gitlab.gnome.org/GNOME/gnome-builder/-/commit/2964f7c2a0729f2f456cdca29a0f5b7525baf7c1
#
# But Nix does not have a fallback path for typelibs like /usr/lib on FHS distros and relies solely
# on `GI_TYPELIB_PATH` environment variable. So, when Ide started to depend on Vte, which
# depends on Pango, among others, GIrepository was unable to find these indirect dependencies
# and crashed with:
#
# Typelib file for namespace 'Pango', version '1.0' not found (g-irepository-error-quark, 0)
./fix-finding-test-typelibs.patch
];

nativeBuildInputs = [
appstream-glib
desktop-file-utils
gi-docgen
(gi-docgen.overrideAttrs (attrs: {
patches = attrs.patches ++ [
(fetchpatch {
url = "https://gitlab.gnome.org/GNOME/gi-docgen/-/commit/f4ff4787cce962b705fb2588b31f2988c5063c13.patch";
sha256 = "11VGFFb2PLVxnX/qUQdLPLfhGQWx4sf4apBP7R2JWjA=";
})
];
}))
gobject-introspection
meson
ninja
pkg-config
python3
python3.pkgs.wrapPython
wrapGAppsHook
wrapGAppsHook4
];

buildInputs = [
ctags
cmark
editorconfig-core-c
flatpak
gnome.devhelp
glade
libgit2-glib
libpeas
libportal-gtk3
vte
gspell
gtk3
gtksourceview4
libportal-gtk4
vte-gtk4
enchant
icu
gtk4
gtksourceview5
json-glib
jsonrpc-glib
libdazzle
libhandy
libadwaita
libpanel
libxml2
ostree
pcre
d-spy
pcre2
python3
sysprof
template-glib
vala
webkitgtk
webkitgtk_5_0
];

checkInputs = [
Expand All @@ -110,6 +131,8 @@ stdenv.mkDerivation rec {

postPatch = ''
patchShebangs build-aux/meson/post_install.py
substituteInPlace build-aux/meson/post_install.py \
--replace "gtk-update-icon-cache" "gtk4-update-icon-cache"
'';

checkPhase = ''
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/src/meson.build b/src/meson.build
index c9a44e418..cd9e466d6 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -35,7 +35,7 @@ foreach test_typelib_dep: test_typelib_deps
test_gi_typelib_path += [join_paths(test_typelib_dep.get_variable('libdir'), 'girepository-1.0')]
endforeach
test_env = [
- 'GI_TYPELIB_PATH=@0@'.format(':'.join(test_gi_typelib_path)),
+ 'GI_TYPELIB_PATH=@0@:@1@'.format(':'.join(test_gi_typelib_path), run_command('sh', ['-c', 'echo "$GI_TYPELIB_PATH"']).stdout().strip()),
'G_TEST_SRCDIR=@0@/tests'.format(meson.current_source_dir()),
'G_TEST_BUILDDIR=@0@/tests'.format(meson.current_build_dir()),
'G_DEBUG=gc-friendly',
8 changes: 4 additions & 4 deletions pkgs/applications/editors/gnome-latex/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@
, gnome
, glib
, pkg-config
, intltool
, gettext
, itstool
, libxml2
}:

stdenv.mkDerivation rec {
version = "3.40.0";
version = "3.41.2";
pname = "gnome-latex";

src = fetchurl {
url = "mirror://gnome/sources/${pname}/${lib.versions.majorMinor version}/${pname}-${version}.tar.xz";
sha256 = "xad/55vUDjeOooyPRaZjJ/vIzFw7W48PCcAhfufMCpA=";
sha256 = "8xDwoUUEmfDP92y5+cXWaZGpUGH6s9bmcMSlZHOF1jM=";
};

nativeBuildInputs = [
Expand All @@ -37,7 +37,7 @@ stdenv.mkDerivation rec {
gobject-introspection
wrapGAppsHook
itstool
intltool
gettext
];

buildInputs = [
Expand Down
Loading

1 comment on commit 7a94322

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat, you pushed a commit directly to master/release branch
instead of going through a Pull Request.

That's highly discouraged beyond the few exceptions listed
on #118661

Please sign in to comment.