Skip to content

Commit

Permalink
Revert "Merge #160259: separateDebugInfo: Use --strip-unneeded"
Browse files Browse the repository at this point in the history
This reverts commit 848091a, reversing
changes made to ab0e692.

It caused issues with elfutils tests,
probably through over-stripping of glibc parts.
  • Loading branch information
vcunat committed Mar 23, 2022
1 parent 2102efd commit a7ccdde
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 40 deletions.
2 changes: 1 addition & 1 deletion pkgs/build-support/setup-hooks/separate-debug-info.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ _separateDebugInfo() {
# firmware blobs in QEMU.)
(
$OBJCOPY --only-keep-debug "$i" "$dst/${id:0:2}/${id:2}.debug"
$STRIP --strip-unneeded "$i"
$STRIP --strip-debug "$i"

# Also a create a symlink <original-name>.debug.
ln -sfn ".build-id/${id:0:2}/${id:2}.debug" "$dst/../$(basename "$i")"
Expand Down
2 changes: 0 additions & 2 deletions pkgs/development/libraries/libpsl/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
, autoreconfHook
, docbook_xsl
, docbook_xml_dtd_43
, glibc
, gtk-doc
, lzip
, libidn2
Expand Down Expand Up @@ -39,7 +38,6 @@ in stdenv.mkDerivation rec {
python3
libxslt
] ++ lib.optionals enableValgrindTests [
glibc.debug
valgrind
];

Expand Down
31 changes: 0 additions & 31 deletions pkgs/development/tools/analysis/valgrind/debug-info-from-env.patch

This file was deleted.

6 changes: 0 additions & 6 deletions pkgs/development/tools/analysis/valgrind/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{ lib, stdenv, fetchurl, fetchpatch
, autoreconfHook, perl
, gdb, cctools, xnu, bootstrap_cmds
, setupDebugInfoDirs
}:

stdenv.mkDerivation rec {
Expand All @@ -20,7 +19,6 @@ stdenv.mkDerivation rec {
url = "https://bugsfiles.kde.org/attachment.cgi?id=143535";
sha256 = "036zyk30rixjvpylw3c7n171n4gpn6zcp7h6ya2dz4h5r478l9i6";
})
./debug-info-from-env.patch
];

outputs = [ "out" "dev" "man" "doc" ];
Expand All @@ -34,10 +32,6 @@ stdenv.mkDerivation rec {
# Perl is also a native build input.
nativeBuildInputs = [ autoreconfHook perl ];

# Not propagatedNativeBuildInputs because of
# https://github.com/NixOS/nixpkgs/issues/64992.
propagatedBuildInputs = [ setupDebugInfoDirs ];

enableParallelBuilding = true;
separateDebugInfo = stdenv.isLinux;

Expand Down

0 comments on commit a7ccdde

Please sign in to comment.