Skip to content

Commit

Permalink
Rebase mermaid, update nodePackages along the way
Browse files Browse the repository at this point in the history
  • Loading branch information
@ysndr
ysndr committed Sep 30, 2020
1 parent dddd1ad commit c1834f4
Showing 1 changed file with 1,718 additions and 1,747 deletions.
Loading

1 comment on commit c1834f4

@infinisil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this broke vega-lite, introduced in #97908. Fails with:

internal/modules/cjs/loader.js:968
  throw err;
  ^

Error: Cannot find module 'vega'
Require stack:
- /nix/store/pg3cvj41h61h84cm46a8g090w88aj22z-node_vega-lite-4.16.8/lib/node_modules/vega-lite/bin/render.js
- /nix/store/pg3cvj41h61h84cm46a8g090w88aj22z-node_vega-lite-4.16.8/lib/node_modules/vega-lite/bin/vl2svg
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/nix/store/pg3cvj41h61h84cm46a8g090w88aj22z-node_vega-lite-4.16.8/lib/node_modules/vega-lite/bin/render.js:3:14)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/nix/store/pg3cvj41h61h84cm46a8g090w88aj22z-node_vega-lite-4.16.8/lib/node_modules/vega-lite/bin/render.js',
    '/nix/store/pg3cvj41h61h84cm46a8g090w88aj22z-node_vega-lite-4.16.8/lib/node_modules/vega-lite/bin/vl2svg'
  ]
}

Looks like bin/vg2svg and co. aren't a bash script anymore, but a node one instead. I'm not sure how this needs to be fixed yet, maybe with some NODE_PATH stuff

Ping @MMesch

Please sign in to comment.